-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA224 > On 2014/10/27 06:58 AM, Timothy Pearson wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA224 >> >>> The new "patches from GIT" page looks good and so does the search field >>> at the bottom. Anyhow IMO there are still a few things to fix: >>> >>> 1) email addresses are shown in full, which is not that good being a >>> page available without any login. >>> It would be advisable to remove them, both from the committer column >>> and >>> the Log message column (for signed-off commits). >> >> While I don't fully agree with this (e.g. anyone can go to CGIT via the >> "View" link and see all the Email addresses there, or even download the >> repositories via GIT and retrieve all the Email addresses automatically >> from that local copy) the Email addresses were wasting valuable space so >> I >> went ahead and removed them. Publicly-known Email addresses are one of >> the hazards of contributing to open source. ;-) >> >>> 2) I believe the correct name of the committer column should be >>> "Author" >> >> Fixed. >> >>> 3) The page still displays with problems if the width of the browser >>> window is small enough (the blue left side menu overlaps the page >>> contents) >> >> Not sure I can do anything about this; E. Liddell would have to comment. >> >>> 4) The search field would probably be better if it was at the top, >>> since >>> it does not take up much page space. At the moment we need to scroll >>> the >>> whole page if we want to search for a particular commit >> >> Reworked. >> >>> 5) the 'page navigation' (the one saying 'Now viewing patches...') >>> would >>> be better if it had links to the next and previous adjacent pages as in >>> most search engines (something like [1], [2], [3], .... to make it >>> clear) >> >> I reworked the navigation system; is it more functional now? >> >>> 6) IMO, the name "Patches from GIT" is misleading for new users, as I >>> already said in a previous email. Would be better to call it "GIT >>> Commits" or "Commit history" or something with "commit" in it >> >> Opinions from the list are welcome here. I will probably go with >> "Commit >> History" if no one else has a better suggestion. >> >>> Hope this is useful. >>> Cheers >>> Michele >> > > Tim, good work, thanks! > Just one thing I think we could improve: the links to [First Page] > [Previous Page] [Next Page] [Last Page] could be either moved or > duplicated at the top of the page. If a user wants to quickly scroll > pages, at this time he has to scroll at the end of each page (or > alternatively modify the address manually). What do you think? I had thought of this yesterday but didn't have time to refactor the code just then. Fixed. :-) > "Commit history" sounds good. Fixed. Thanks for your input! Tim -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iFYEARELAAYFAlRObocACgkQLaxZSoRZrGFtDgDgg4vLBt6i4EfU70stD5x2vD9W OKATOTWozhPzZwDfQ+e7JS+YXo7FoQZDGAa28NNRNy01Sx65Gp87lQ== =BCbM -----END PGP SIGNATURE-----