trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: June 2016

Re: Re: test target and code

From: deloptes <deloptes@...>
Date: Tue, 21 Jun 2016 08:23:51 +0200
Fat-Zer wrote:

> Some notes to be taken into account:
> 1) There are two types of checks:
> - "make check" builds test snippets that are required to be run by
> the user and see if they produce correct output
> - "make test" runs those few which are intended to be run as part
> of automatic system
> 2) The programs themselves are broken (mostly they have same mistake
> related to changed TDEApplication constructor signature)
> 

This sounds good. Thank you!

> I may fix the cmake stuff for you, if you will repair the programs
> themselves (95% is to change 1 line, but I wouldn't trust in that
> particular case to a script) and do the testing (at least make sure
> that all checks are getting run and won't crash instantly).

Indeed I have noticed this. An example is the tdepim calendar tests I tried
recently. When there is DTSTART; DATE: 20030901, I get in the test result
file DTSTART: 201606......T.....Z
It could be we broke something by fixing the null date/time issue

> Also for doing it right I will follow the order: tdelibs -> tdebase ->
> tdepim.
> 

This is also a good hint. Thanks

regards