trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: February 2020

Re: Re: Re: git modules and cmake/admin submodules

From: deloptes <deloptes@...>
Date: Mon, 17 Feb 2020 20:34:49 +0100
Michele Calgaro via trinity-devel wrote:

> Hi Emanoil,
> if you made changes on cmake, you need to create a PR on common cmake
> module. Be aware that those changes will be seen in all modules, so make
> sure they are genearal and not specific for kplayer. Cheers
> Michele

Thank you Michele,

in common/cmake there are only TDE related. What I am missing is cmake to
check if libdvdread, libdvdnav, libdvdcss was installed also if
WITH_ALL_OPTIONS=ON to enable WITH_DVDCSS.

Might be the functionality should go into the local ConfigureChecks.cmake ?

pls advise

thanks