trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: February 2020

Re: [trinity-devel] Re: Re: Re: git modules and cmake/admin submodules

From: "Michele Calgaro via trinity-devel" <trinity-devel@...>
Date: Tue, 18 Feb 2020 08:53:44 +0800
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512


> Thank you Michele,
>
> in common/cmake there are only TDE related. What I am missing is cmake to check if libdvdread, libdvdnav, libdvdcss
> was installed also if WITH_ALL_OPTIONS=ON to enable WITH_DVDCSS.
>
> Might be the functionality should go into the local ConfigureChecks.cmake ?
>
> pls advise
>

ok, in that case you probably need to make changes to the cmake files in kplayer, not to the common module. So those
chagnes would go in the same PR as kplayer. Not sure I had misunderstood your original statement "I made changes to
cmake" :-)
Cheers
  Michele

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEjhl1z5vbYB3YbFTiKnW3yore1c8FAl5LNZIACgkQKnW3yore
1c/mgg//czzZfOEBTfh5OwK6wm7dIHbHVNPWvy3GNpsI1M/JHq+TsEYu9gEIF5aX
lIyDfRAUZSkTB72ORiWi3IeRdxyoURo5/TFMii5l7xW2j4wvILUQhI6Okhlp6ZwE
ZzrQlRSiBDyRxDsza/m5C203igjovUrvc6exuStinKawkefpNisstuocLM90SrL5
zV4xqIOdKInQNVcCHswaJZK3e15ukUJdF1oH8lv0SNHWiPLe89RwEG0qUJCZhXwi
ukcQiopswITofkHHRFNiij9lPvsyJa2xh658KxuJUr3N3czuJCab8kEFCG9twJw4
gxeWqlxdcWXbH3AGizHXPSrtiUylwIX2oGyKXgqbZOr9W8toDnhxnbLTjz8hH90o
4ctvWMq8c7mj8Gj7wfv3m5S1ul+oXg8J1O1crPbyi/votmR1ViLGgFHsu7JMWwwb
pYIasnCYW6UMKGNo0fNqM3vTpu0xt851naWxAJdl3Imo8CcvjCBUHY0YnV0GQJkK
2/g5pF8lhHprfC/fsbKD4U4c+ALOofkOcIvBl2gFQkvA56pm14Ow9VNQxv1Bguh4
Dq/SlFWxBHRTU8267qtIs6cTeZ6TMte2Ho8d8IqRaWlnF4A+8qDrtVcXlw8zeXXT
im1jhKS8asfQjoryoAbOJEd+b3pGoxZAFdqdsjpjCHPxVuxlvfk=
=5ale
-----END PGP SIGNATURE-----