trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: April 2012

Re: [trinity-devel] Bug 958 opened - gcc 4.7 build failures

From: "David C. Rankin" <drankinatty@...>
Date: Thu, 05 Apr 2012 19:20:28 -0500
On 04/05/2012 07:10 PM, Darrell Anderson wrote:
> Will the patch hurt or confuse the build with pre gcc 4.7 systems?
> 
> Darrell

I have no Freaking idea :)

It depends - presumably it should make a difference since it simply adds the

'this->' designation to the calls inside the template stuff, but I no 'nada'
about the template library, etc... If I had something other than Arch, I'd give
it a go. (I have suse, but I don't write .spec files :)

Maybe I should install Slack 13.37 and give that a spin.

I don't think it will hurt the earlier builds, since it just satisfies the
compiler checks. Here is the patch:

--- kicker/applets/launcher/easyvector.h
+++ kicker/applets/launcher/easyvector.h	2012-04-05 17:33:50.320708865 -0500
@@ -87,7 +87,7 @@
 template < class VALUE, bool CHECKINDEX >
 void EasyVector< VALUE, CHECKINDEX >::eraseAt(Index index)
 {   _checkIndex(index);
-    erase(this->begin()+index);
+    this->erase(this->begin()+index);
 }


@@ -108,7 +108,7 @@
         this->push_back(value);
         return;
     }
-    insert(this->begin()+index,value);
+    this->insert(this->begin()+index,value);
 }


@@ -116,7 +116,7 @@
 void EasyVector< VALUE, CHECKINDEX >::insertAt(EasyVector< VALUE, CHECKINDEX
>::Index index,const EasyVector< VALUE, CHECKINDEX > &v)
 {   index=_convertInsertIndex(index);
     _checkInsertIndex(index);
-    insert(this->begin()+index,v.begin(),v.end());
+    this->insert(this->begin()+index,v.begin(),v.end());
 }


-- 
David C. Rankin, J.D.,P.E.