trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: April 2012

Re: [trinity-devel] Darrell - komp-pid.diff -> kdelibs build fail (More info)

From: /dev/ammo42 <mickeytintincolle@...>
Date: Tue, 10 Apr 2012 07:34:59 +0200
On Mon, 09 Apr 2012 22:30:56 -0500
"David C. Rankin" <drankinatty@...> wrote:

> Darrell,
> 
>   I started a new build of tde tonight from scratch. I grabbed the
> output of the build failure in tdelibs due to komp-pid.diff. (I know
> it is experimental -- I was experimenting :) It is another "error:
> cannot convert 'TQString' to 'const char*' in assignment" in
> tdelibs/tdecore/kapplication.cp:
> 
> [  6%] Building CXX object
> tdecore/CMakeFiles/tdecore-shared.dir/kapplication.cpp.o
> cd /build/src/build/tdecore && /usr/bin/c++
> -Dtdecore_shared_EXPORTS -DHAVE_CONFIG_H -march=i686 -mtune=generic
> -O2 -pipe -fstack-protector --param=ssp-buffer-size=4
> -D_FORTIFY_SOURCE=2   -DQT_NO_ASCII_CAST -DQT_CLEAN_NAMESPACE
> -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -DQT_THREAD_SUPPORT
> -D_REENTRANT -include tqt.h -fPIC -I/opt/tqt3/include
> -I/usr/include/tqt -I/build/src/build/tdecore -I/build/src/build
> -I/build/src/tdelibs/tdecore -I/build/src/tdelibs/tdecore/network
> -I/build/src/tdelibs/dcop -I/build/src/tdelibs/libltdl
> -I/build/src/tdelibs/tdefx -I/build/src/tdelibs/tdeui
> -I/build/src/tdelibs/kio/kio -I/usr/include/libart-2.0    -o
> CMakeFiles/tdecore-shared.dir/kapplication.cpp.o
> -c /build/src/tdelibs/tdecore/kapplication.cpp /build/src/tdelibs/tdecore/kapplication.cpp:2039:2:
> warning: #warning This should be already in Qt, check.
> [-Wcpp] /build/src/tdelibs/tdecore/kapplication.cpp: In static member
> function 'static bool
> KApplication::isCompositionManagerAvailable()': /build/src/tdelibs/tdecore/kapplication.cpp:1791:47:
> error: cannot convert 'TQString' to 'const char*' in
> assignment /build/src/tdelibs/tdecore/kapplication.cpp: In member
> function 'TQt::HANDLE
> KApplication::getX11RGBAVisual(Display*)': /build/src/tdelibs/tdecore/kapplication.cpp:1911:10:
> warning: converting to non-pointer type 'TQt::HANDLE {aka long
> unsigned int}' from NULL
> [-Wconversion-null] /build/src/tdelibs/tdecore/kapplication.cpp: In
> member function 'TQt::HANDLE
> KApplication::getX11RGBAColormap(Display*)': /build/src/tdelibs/tdecore/kapplication.cpp:1921:10:
> warning: converting to non-pointer type 'TQt::HANDLE {aka long
> unsigned int}' from NULL
> [-Wconversion-null] /build/src/tdelibs/tdecore/kapplication.cpp: In
> static member function 'static void
> KApplication::sigpipeHandler(int)': /build/src/tdelibs/tdecore/kapplication.cpp:3595:31:
> warning: ignoring return value of 'ssize_t write(int, const void*,
> size_t)', declared with attribute warn_unused_result
> [-Wunused-result] /build/src/tdelibs/tdecore/kapplication.cpp: In
> member function 'bool
> KApplication::detectCompositionManagerAvailable(bool,
> bool)': /build/src/tdelibs/tdecore/kapplication.cpp:1876:42: warning:
> ignoring return value of 'size_t fwrite(const void*, size_t, size_t,
> FILE*)', declared with attribute warn_unused_result [-Wunused-result]
> make[2]: ***
> [tdecore/CMakeFiles/tdecore-shared.dir/kapplication.cpp.o] Error 1
> make[2]: Leaving directory `/build/src/build' make[1]: ***
> [tdecore/CMakeFiles/tdecore-shared.dir/all] Error 2 make[1]: Leaving
> directory `/build/src/build'
> 
>   So far the build is progressing with all other patches:
> 
>   patch -Np0 -i ${pkgname#*-}-XDG-KDE-TDE.diff
> 
>   ## patch kde help dir
>   patch -Np0 -i ${pkgname#*-}-helpdir.diff
> 
>   ## patch KDE4-detect
>   patch -Np0 -i ${pkgname#*-}-KDE4-detect.diff
> 
>   ## patch kdetcompmgr
>   patch -Np0 -i ${pkgname#*-}-kdetcompmgr.diff
> 
>   ## patch recentdocs
>   patch -Np0 -i ${pkgname#*-}-recentdocs.diff
> 
>   ## patch kdirwatch
>   patch -Np0 -i ${pkgname#*-}-kdirwatch.diff
> 
> I'll report back on the kdirwatch patch improvements once the build
> is done.
I think the right fix for the komp-pid.diff related error is to replace
the Unix/Standard C function calls (that take C strings) to Qt ones, as
there don't seem to be any easy way to convert back TQString to const
char* without messing with locales (TQString is UTF16, const char* is
locale-dependent).