trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: April 2012

Re: [trinity-devel] SOLVED [was Re: [trinity-devel] tdepim - gcc47 - need help with "which redeclared 'it' is right 'it'?"]

From: "Timothy Pearson" <kb9vqf@...>
Date: Wed, 18 Apr 2012 21:15:36 -0500
> On 04/18/2012 07:14 PM, Darrell Anderson wrote:
>>> Now all we need is help with digikam libpng15 issues and
>>> then I can fix the gcc47 build issues there. Implementing the libpng15
>>> fixes
>>> will take a more seasoned coder than I. Fixing build issues is one
>>> thing, but
>>> implementing library changes - not even close..
>>
>> Check the mail list archives. I posted a digikam patch about a week ago.
>> Here:
>>
>> http://humanreadable.nfshost.com/trinity/patches/digikam/digikam-libpng15.diff
>>
>> No promises. As I mentioned previously, I only added preprocessor tests
>> for the versions, as I did with the gwenview patch. Even if the updated
>> patch fails, the preprocessor tests are needed anyway.
>>
>> Darrell
>
>
> Thanks Darrell,
>
>   The preprocessor stuff works, but the digikam build still fails in the
> same
> spot. I've looked and it's Greek to me. We need an experienced coder to
> take a
> look at this one...
>
> pngloader.cpp: In member function 'virtual bool
> Digikam::PNGLoader::load(const
> TQString&, Digikam::DImgLoaderObserver*)':
> pngloader.cpp:129:9: error: invalid use of incomplete type 'png_struct
> {aka
> struct png_struct_def}'
> In file included from ../../../../digikam/digikam/daboutdata.h:36:0,
>                  from pngloader.cpp:51:
> /usr/include/png.h:857:16: error: forward declaration of 'png_struct {aka
> struct
> png_struct_def}'
> pngloader.cpp: In member function 'virtual bool
> Digikam::PNGLoader::save(const
> TQString&, Digikam::DImgLoaderObserver*)':
> pngloader.cpp:540:9: error: invalid use of incomplete type 'png_struct
> {aka
> struct png_struct_def}'
> In file included from ../../../../digikam/digikam/daboutdata.h:36:0,
>                  from pngloader.cpp:51:
> /usr/include/png.h:857:16: error: forward declaration of 'png_struct {aka
> struct
> png_struct_def}'
> pngloader.cpp:677:39: warning: deprecated conversion from string constant
> to
> 'png_charp {aka char*}' [-Wwrite-strings]
> pngloader.cpp: In member function 'long int
> Digikam::PNGLoader::formatStringList(char*, size_t, const char*,
> __va_list_tag*)':
> pngloader.cpp:985:55: warning: function might be possible candidate for
> 'gnu_printf' format attribute [-Wmissing-format-attribute]
> pngloader.cpp: In member function 'virtual bool
> Digikam::PNGLoader::load(const
> TQString&, Digikam::DImgLoaderObserver*)':
> pngloader.cpp:96:41: warning: ignoring return value of 'size_t
> fread(void*,
> size_t, size_t, FILE*)', declared with attribute warn_unused_result
> [-Wunused-result]
>
>
> --
> David C. Rankin, J.D.,P.E.

The jmpbuf usage should be fixed in GIT hash 7d0d82b.  Let me know if you
run into any further digikam build problems...

Tim