trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: April 2012

Re: [trinity-devel] sftp_kio - fix ssh port number read

From: "David C. Rankin" <drankinatty@...>
Date: Wed, 25 Apr 2012 09:28:43 -0500
On 04/25/2012 02:05 AM, Timothy Pearson wrote:
> The recent problem arose due to the fact that the port number was ALWAYS
> being specified via the removed code.  The new code sets mPort to -1 if a
> port number was not manually passed to kio_sftp, thus indicating that the
> optional port parameter should NOT be passed to the ssh process on
> invocation.
>
> Does this make sense?
>
> Tim

Yep,

   Makes perfect sense. I looked over that part of the code 15 times, looking 
at it with a strange look on my face (wondering - "Is that right?"), but not 
being able to see through the process to what happens either way and what 
difference it made. That is the "You would need to know some of how kio_sftp 
operates to know what I did..." that I simply didn't have.

   I'm glad it is fixed!

   Uh-oh! Just saw the update 'openssh-6.0p1-1' ready to install. We'll go 
give it a test and report back. I'm sure it will be no issue :)

-- 
David C. Rankin, J.D.,P.E.