Message: previous - next
Month: June 2012

Re: [trinity-devel] Proposed patch: Kate/Kwrite version numbers

From: Darrell Anderson <humanreadable@...>
Date: Thu, 7 Jun 2012 09:40:21 -0700 (PDT)
> > With the patch both kate and kwrite display a version
> number of 14.0.0.
> > 
> > Any objections to pushing?
> > 
>   With all these version numbers -- Why are the version
> number not 3.5.14? To me
> 14.0.0 has no meaning. I know what 3.5.14 is, why not have
> the full version?
> Every time I have to dig into the code, I see checks for
> primary versions of 3
> or 4, and then minor numbers of >= 2, etc... No where do
> I see primary version
> of 14. I don't know if it makes a difference, but I thought
> the about dialogs
> should read the actual version number (eg 3.5.14)

To me all of the various version numbers are flaky. Change them all to R14.0.0? Then all version numbers become useless because they all match the release number.

Kate/kwrite are the weirdest. Version numbers of 15.0.0 and 13.0.0 respectively look crazy -- not credible. Just like Chrome and Firefox version numbers are not credible.

The calculation method for kate/kwrite worked okay in the previous 3.x.x scheme but blows up with the R14 scheme. My patch retains the calculation method, which then matches the release version. A simple fix. If we want to retain the old version schemes for both apps then we need to reset/hard-code the first and second numbers of the version numbers to 2.5 and 4.5 respectively, and sync the third number with Trinity's R MAJOR number (14). That version scheme makes sense to me too.

I will try to test that idea with a new patch.

Julius explained the new version scheme. Check the mail list archives for further discussion. Many patches in Trinity broke backwards binary compatibility. Further, the new version scheme severs Trinity from KDE 3.5.10 to mold a new identity. Yet like many decisions in life, simple changes suffer from the effects of the "law of unintended consequences." I like the new release version scheme but don't like how that change affects the kate/kwrite versions.

I don't want us wasting time debating version schemes --- we have far more important bugs to resolve if we are ever to release R14. I just want kate and kwrite to have credible version numbers. The slogan "Image is everything" does have merits to a certain degree. :-)