Message: previous - next
Month: June 2012

Re: [trinity-devel] Proposed patch: Kate/Kwrite version numbers

From: Darrell Anderson <humanreadable@...>
Date: Thu, 7 Jun 2012 11:04:01 -0700 (PDT)
> To me all of the various version numbers are flaky. Change
> them all to R14.0.0? Then all version numbers become useless
> because they all match the release number.
> Kate/kwrite are the weirdest. Version numbers of 15.0.0 and
> 13.0.0 respectively look crazy -- not credible. Just like
> Chrome and Firefox version numbers are not credible.
> The calculation method for kate/kwrite worked okay in the
> previous 3.x.x scheme but blows up with the R14 scheme. My
> patch retains the calculation method, which then matches the
> release version. A simple fix. If we want to retain the old
> version schemes for both apps then we need to
> reset/hard-code the first and second numbers of the version
> numbers to 2.5 and 4.5 respectively, and sync the third
> number with Trinity's R MAJOR number (14). That version
> scheme makes sense to me too.
> I will try to test that idea with a new patch.

I created and tested a new patch for the kate and kwrite version numbers. I hard-coded the first two numbers and synced the third number to the Trinity release.

With the patch Kate's version number becomes 2.5.14 and kwrite's version number becomes 4.5.14. For those unfamiliar, the respective versions in KDE 3.5.10 were 2.5.10 and 4.5.10. I don't have a 3.5.13 testing environment, but I presume the respective versions there were 2.5.13 and 4.5.13.

The patch retains that consistency and has comments why the new version calculation method is used.

Here is the patch should anybody want to help test or review:

Tim, any objections to pushing to GIT?