Message: previous - next
Month: June 2012

Re: [trinity-devel] digikam FTBFS - libpng15 patch regression or not applied?

From: Darrell Anderson <humanreadable@...>
Date: Tue, 26 Jun 2012 18:29:12 -0700 (PDT)
> > I wonder how that happened.  Fixed in GIT hash 18ecd51.
> > 
> Gremlins.... If that is the only place they appear -- we are
> lucky :)

As this is a patch to remedy building against libpng 1.5, why are preprocessor checks not needed with this patch?

While the Trinity servers were cut off from the world this afternoon, I built digikam against 1.4.9 with my own patch, that David tested as well against libpng 1.5:

I just now built digikam without failure against libpng 1.4.9 with the GIT patch, which does not have preprocessor checks.

Why did the old code compile against 1.4.9 and again compile against 1.4.9 with the patch?