On 06/27/2012 03:04 PM, Darrell Anderson wrote: > Considering the original volume of changes needed, we're about as okay as we > can expect, but --- we still find branding issues. For example, today I found > some more and I am pushing patches. > > To resolve remaining branding issues we need the following: > > * Some really smart person to grep the system properly looking for corrupt > image files (png, xcf, jpg/jpeg, whatever else might be out there). We can't > inspect those images for branding issues. For whatever reason, seems many of > the images got corrupted with CR/LF issues. We have found most of the corrupt > files (walch.martin found most of them --- I only pushed clean files), but I > don't know of a good way to search the sources for corrupt image files. > > (Note: Corrupt image files do not block building packages, but they cause > usability issues that reflect badly on us). > This is tricky. Using 'file' to test even the corrupt jpeg images will return a valid jpeg header in most cases and miss the fact that the image is corrupt. I don't mind grepping or running find tde/main -type f -name "*.jpg" -execdir <what> '{}' \;, but I need to know what <what> will do the trick. Ideas? > * Some really smart person to grep the system looking for text strings > containing KDE. I haven't figured out a slick way to search the sources for > these branding issues. Again, I think we have found most but we continually > find more, albeit a smaller number of these strings appear each time. The > challenge is we *cannot* do a blind global search-and-replace. We are at the > point where we have to review each potential suspect string in context to > ensure we are updating human-viewable text strings and not code strings. > I'll give it a go. It will take either a recursive grep with an exclude or some global find with an -exec that uses file to test for searchable files -- or some combination of the two. Do you have any examples of what doesn't work so I don't reinvent a nonworking wheel :) > * Some really smart person to figure out how the fifteenpieces applet About > dialog is sucking in a KDE3 branded image (bug report 1052). I don't know > whether the problem is limited to fifteenpieces or whether the image being > used is a global default About image. One way or another we need to find that > image and update. > Fun... I think I still have the old threads. > * Internationalization (tde-i18n) files are beyond me. (+1) -- David C. Rankin, J.D.,P.E.