Message: previous - next
Month: July 2012

Re: [trinity-devel] Bug 1119 - opened to track scope/declaration ftbfs for k3b, k9copy, kdmtheme, krusader

From: "David C. Rankin" <drankinatty@...>
Date: Mon, 23 Jul 2012 17:54:07 -0500
On 07/23/2012 05:33 PM, David C. Rankin wrote:
>   Along with the drop of AVFormatParameters it looks like 'av_open_input_file'
> is deprecated in favor of 'avformat_open_input'. Thankfully there are only 4
> instances of this in k9copy (k9author/k9avidecode.h k9author/k9avidecode.cpp).
> 17:19 archangel:/dat_e/tmp/src/k9copy> grep -r av_open_input_file *
> k9author/k9avidecode.h:typedef int (*av_open_input_file_t)(AVFormatContext **,
> const char *,AVInputFormat *,int, AVFormatParameters *);
> k9author/k9avidecode.h:    av_open_input_file_t av_open_input_file;
> k9author/k9avidecode.cpp:    av_open_input_file =
> (av_open_input_file_t)dlsym(FormatHandle,"av_open_input_file");
> k9author/k9avidecode.cpp:    if (av_open_input_file(&m_FormatCtx,
> _fileName.utf8(), NULL, 0, NULL)!=0) {

>   Experts - what say you? This will take an experienced eye.

ffmpeg change also affects k3b:

17:47 archangel:/dat_e/tde/main/applications> grep -r av_open_input_file k3b/
k3b/plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp:  int err = av_open_input_file(
&d->formatContext, m_filename.local8Bit(), 0, 0, 0 );

errors that need fixing:

k3bffmpegwrapper.cpp: In member function 'bool K3bFFMpegFile::open()':
k3bffmpegwrapper.cpp:82:84: error: 'av_open_input_file' was not declared in this
k3bffmpegwrapper.cpp:131:63: error: 'dump_format' was not declared in this scope

(there are numerous other deprecation warnings in k3b...)

I'll work more with k3b in a bit. The k9copy ftbfs is the one I need the most
help with right now.

David C. Rankin, J.D.,P.E.