Message: previous - next
Month: August 2012

Re: [trinity-devel] tdebase: WITH_HAL=OFF

From: "Timothy Pearson" <kb9vqf@...>
Date: Mon, 13 Aug 2012 01:40:39 -0500
>>> > Seems then that my temporary patch is best? Just delete
>>> the if( WITH_HAL ) test and build with dbus-tqt support regardless of
>>> how
>>> WITH_HAL or WITH_TDEHWLIB are set?
>>> I would check to see if either WITH_HAL or WITH_TDEHWLIB are
>>> set before requiring dbus-tqt; if neither are set then tdebase does not
>>> depend on it.
>> I ran a tdebase build with WITH_HAL=NO, WITH_TDEHWLIB=NO and no related
>> patching. The build fails with the same error about not finding
>> dbus/dbus.h. The failure occurs when building tdm backend, in
>> consolekit.c.
> Sounds like the code in consolekit.c is not properly guarded with #ifdefs,
> which would be set when dbus-tqt is found.
> Tim

Is there any good reason that dbus might not be available on a target
distribution/system?  If not, I would say to just make dbus a tdebase
dependency and remove the if statements from around the dbus checks.  If
there is a good reason for dbus to be missing, then we will need to add
another flag to build without dbus support and also add the requisite
#ifdefs to the tdm consolekit code.