trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: August 2012

Re: [trinity-devel] Bug 1119 - opened to track scope/declaration ftbfs for k3b, k9copy, kdmtheme, krusader

From: Slávek Banko <slavek.banko@...>
Date: Mon, 13 Aug 2012 23:59:30 +0200
On Monday 23 of July 2012 22:24:20 David C. Rankin wrote:
> On 07/20/2012 04:16 PM, David C. Rankin wrote:
> > Tim, All,
> >
> >    To track the recent handful of ftbfs for k3b, k9copy, kdmtheme,
> > krusader due to scope/declaration issues that have surfaced, I have
> > opened:
> >
> > http://bugs.pearsoncomputing.net/bugzilla/show_bug.cgi?id=1119
> >
> >    That will provide a common point to work from.
>
> The failure in k9copy and likely k3b is due to ffmpeg 0.11-1. Since the
> updates to ffmpeg contain potential security related fixes, I elevated the
> bug to a blocker for R14. See: http://ffmpeg.org/
>
> I'm trying to figure out what needs to be fixed in k9copy. Any help
> appreciated.

The ffmpeg patch for k9copy is ready. I just was not sure replacing from 
cur_st->cur_dts to packet.dts. But as it turned out function readFrame have 
some other problems - causes the crash. So the function would need to fix, 
regardless of the ffmpeg patch.

Therefore I propose to push the ffmpeg patch as it is and repair of function 
readFrame to solve separately. Any objections, suggestions, comments, other 
better patches? ;)

Slavek
--