On 08/18/2012 10:30 AM, Slávek Banko wrote: > > Let me disagree. > > Can I mention again that, included "renaming" patches are: > + Rename old tq methods that no longer need a unique name > + Remove additional unneeded tq method conversions > + Rename obsolete tq methods to standard names > + Rename a few stragglers > + Fix inadvertent "TQ" changes > > These patches change such names, which anyway are in tqtinterface handled > using "#define" - for example: #define tqsetSizePolicy setSizePolicy. These > patches can not break the ABI. And not require recompilation of others. > > Exceptions that require recompiling a few other packages I mentioned earlier: > http://trinity-devel.pearsoncomputing.net/?0::9413 > > 513ffc6e patch is different from the above. This patch changes the ABI and > affects a large number of packages, which would have to be recompiled. > Therefore, this patch (though is very small) for me seems with a too big > impact than they should have a patches for SRU. > > Slavek > Francios, Slavek, I do not understand the issue at the ABI level, but I would advise only implementing the *necessary* name changes. I have had fits with the k->t renames on numerous files breaking builds that are frustrating to fix. I don't mind doing it if the change is necessary, but wholesale renaming just for the sake of it should be avoided. I will defer to your wisdom on this, but we absolutely need kpowersave to work. I don't mind rebuilding, so if it makes sense do it. But the foundation of 3.5.13-1 should be as close to 3.5.13 as possible... -- David C. Rankin, J.D.,P.E.