Message: previous - next
Month: August 2012

Re: [trinity-devel] 3.5.13-sru avahi-tqt (patch) - just need to pick commit and backport

From: Slávek Banko <slavek.banko@...>
Date: Sun, 26 Aug 2012 14:15:49 +0200
On Friday 24 of August 2012 17:20:08 David C. Rankin wrote:
> On 08/24/2012 10:11 AM, David C. Rankin wrote:
> >   As with the other person who originally posted
> >, the change is 
> > necessary so that correct *directory* information is provided for the 
build. You
> > must be exporting some path somewhere in your build such that telling 
make to
> > use the correct directory information with '$^' results in double-path
> > information in your build.  I don't know. It is either broken on your 
end or on
> > my end. I'm not using any exports to build, just the code from GIT. 
> > just from GIT without altering the environment requires the patch I 
> I'll test the patch and report back. Looking closely at what my patch 
does and
> what your patch does, I appears that they both accomplish the same thing
> regarding the path information from 2 different directions:
>    AC_PATH_PROGS(MOC_QT3, [moc-tqt], no, [$QT3_PREFIX:$PATH])
> You seem to be providing the ':$PATH' information explicitly, while:
> '$^' is a list of all the prerequisites of the rule, including the names 
of the
> directories in which they were found.
>   What I don't know is which is the 'most correct' way to do it. After 
> if your works for my build, I'm happy just pushing yours. Will report 


I read the comments for bug 920, which addresses exactly the same problem. 
After all, refers the same proposed patch. But comments confirm what I 
have also stated. Patches 18173187 (partially) and 7b10d93d cherry picked 
into v3.5.13-sru.