Message: previous - next
Month: March 2016

Re: [trinity-devel] CMake + tdelfeditor × versioned libraries

From: Michele Calgaro <michele.calgaro@...>
Date: Tue, 15 Mar 2016 08:59:54 +0100
On 03/14/2016 10:18 PM, Sl�vek Banko wrote:
> Hi all,
> I noticed one problem regarding the cmake build of libraries with versioning 
> and tdelfeditor. Tdelfeditor is used not only on file with the appropriate 
> version, but also on base 'so' file without a version number. However, this 
> is a symlink to the file with the appropriate version. Use tdelfeditor causes 
> that instead of this symlink is created a regular file. Results are then two 
> full 'so' files, which is incorrect. For example, in tdebase (current stable 
> R14.0.3 Wheezy@amd64):
> - size 809232 (package libkonq4-trinity-dev)
> - size 809240 (package libkonq4-trinity)
> Solutions should be simple: in the common cmake module run tdelfeditor only on 
> libraries with the appropriate version and on base files only if the library 
> is not versioned. In some cases tdelfeditor is used, although library is not 
> shared == tdelfeditor is started without valid arguments. See proposed patch.
> I believe that there is no reason against to push the patch. There will be 
> only one consequence - the patch causes rebuild almost all packages.
Hi Slavek,
no problem if the patch needs to be pushed.
Anyhow I do not see this problem on my system. See attached screenshot, tdebase rebuilt 3 days ago.
Maybe something else?