Message: previous - next
Month: December 2011

Re: [trinity-devel] Need help with patch

From: Darrell Anderson <humanreadable@...>
Date: Thu, 8 Dec 2011 16:09:12 -0800 (PST)
> Just to make sure, are you running the autoconf
> regeneration tool after
> you change the files?  Usually it is run
> like this:
> make -f admin/Makefile.common
> If you are, check for any files.  If
> they exist they will
> overwrite the file contents.

I found the problems.

One was mine. I changed the test of RUBY_VERSION_MINOR == 8 to RUBY_VERSION_MINOR >= 8. The change was unnecessary and worse, in the wrong direction. Changing to <= succeeds but >= fails everything. :)

The other is the include to version.h needs to be ruby/version.h for 1.9.1.

My new patch seems to succeed with my setup, which includes 1.9. I presume the patch will still work correctly with 1.8, but somebody should test.

Patch uploaded to bug report 721 (