trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: February 2020

Re: [trinity-devel] Re: Re: git modules and cmake/admin submodules

From: "Michele Calgaro via trinity-devel" <trinity-devel@...>
Date: Mon, 17 Feb 2020 17:23:32 +0800
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

> Hi Slavek,
>
> this solves only kplayer part, but cmake is still @master and when I do something there it says:
>
> repo-master/tde/1_git/tde/main/applications/kplayer$ git status On branch issue/1/kplayer Changes not staged for
> commit: (use "git add <file>..." to update what will be committed) (use "git checkout -- <file>..." to discard
> changes in working directory) (commit or discard the untracked or modified content in submodules)
>
> modified:   CMakeLists.txt modified:   cmake (untracked content)
>
>
> repo-master/tde/1_git/tde/main/applications/kplayer$ git submodule status cmake
> 8668335711fa13cec276552d75bfbb4285c7edb0 cmake (r14.0.0-60-g8668335)
>
>
> thank you in advance
>
> regards
>

Hi Emanoil,
if you made changes on cmake, you need to create a PR on common cmake module. Be aware that those changes will be seen
in all modules, so make sure they are genearal and not specific for kplayer.
Cheers
  Michele
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEjhl1z5vbYB3YbFTiKnW3yore1c8FAl5KW40ACgkQKnW3yore
1c/Q8Q/9H4I9qrfO75TwM/hdBNuYgYM0yjJob4M4cGLSbPhDsetmCo+oZteD8hnL
TokOAAshI9fXsu+cw0vmfN/Z758zlEhLGhDGVPfHoF3hWh1avBbIMIIdxITwGF/w
RwZqKPc08v51XEywz05IK5r6W6ym7TAUNieyvCghDZj3CSKMoFJ9VqTWr+xE2oEy
9hkmuobXbA7oZpcOVGlnMyn5fBHPGgUkUV5Xbp/UdH9DQNsjUQTvROCftPWYhruH
7886cEm4kH0ejMIxT97aA0zXkYu+yrY+CsyrpqQg9d7kYWgL1cZM3BkNxPOtakQi
lDOE53j0e4Ie8Dpp0HIKn0Ou/Ci41TFdDw1Jd7cHxPitwqF5SNvnXZiazoZfymgU
Uu+9Bzv/33vp85A3XOZAcyQyX+ZioJE8M3CdfocmYsQthPaFvVLD4NVyDRIXHkoD
bomQMdPyA1nfRJwXuKPp1fc4e0/6S9VNsb5aw5f/yoFZGAySbM1R+kkAs3SNsmTr
xSQWCxWSir63rzZDTqWn08yfBa/3rfVm6CuWbvhAAZmJdNFBaKHOEC5hFt89gtbM
TuW26DfqeimufBLDHeBEqKeNrN5y6Z5EsOgiFFlM+pqUdWKLGtbR5TL7TOsHRs9s
aJuqJ1xFoeV01UkTuDhi4KiE4IgsHqS7F8kWdvA4foA+T4L4qcg=
=OGSl
-----END PGP SIGNATURE-----